Conversation
ptodev
reviewed
Jan 15, 2026
kalleep
changed the title
ptodev
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
When we detect that a file is deleted we drain anything left from the opened fd. But then we tried to reopen then new file created.
I am working better integration tests for this component and discovered that we could miss these buffered lines if the file was deleted and no new file would was created. What we want to do is to be able to consume these even if a new file never is created and the target disappear eventually.
So before this pr if a file was deleted and we successfully drained the rest of the file these would not be returned before the new filed appeared because we would be stuck waiting on this new file.
It is safe to return here because we will return buffered lines and then get the same event again.
The test I added fails on main.
Issue(s) fixed by this Pull Request
Notes to the Reviewer
PR Checklist